NodeBB 1.7.1 Update Issues

[scottalanmiller]

Errors going from NodeBB 1.7.0 to 1.7.1, opened a thread on NodeBB...

https://community.nodebb.org/topic/11579/errors-on-update-to-1-7-1

create mode 100644 src/prestart.js
 create mode 100644 src/upgrades/1.7.1/notification-settings.js
 create mode 100644 src/views/emails/notification.tpl
 create mode 100644 test/emailer.js
/opt/kae-1.0/src/cli/index.js:39
	.description('Welcome to NodeBB')
	 ^

TypeError: program.name(...).description is not a function
    at Object.<anonymous> (/opt/kae-1.0/src/cli/index.js:39:3)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/kae-1.0/nodebb:5:1)
    at Module._compile (module.js:570:32)
/opt/kae-1.0/src/cli/index.js:39
	.description('Welcome to NodeBB')
	 ^

TypeError: program.name(...).description is not a function
    at Object.<anonymous> (/opt/kae-1.0/src/cli/index.js:39:3)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/kae-1.0/nodebb:5:1)
    at Module._compile (module.js:570:32)
npm WARN eslint-config-airbnb@13.0.0 requires a peer of eslint@^3.9.1 but none was installed.
npm WARN eslint-config-airbnb-base@10.0.1 requires a peer of eslint@^3.9.1 but none was installed.
npm WARN eslint-plugin-jsx-a11y@2.2.3 requires a peer of eslint@^2.10.2 || 3.x but none was installed.
npm WARN eslint-plugin-react@6.9.0 requires a peer of eslint@^2.0.0 || ^3.0.0 but none was installed.
/opt/kae-1.0/src/cli/index.js:39
	.description('Welcome to NodeBB')
	 ^

TypeError: program.name(...).description is not a function
    at Object.<anonymous> (/opt/kae-1.0/src/cli/index.js:39:3)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/kae-1.0/nodebb:5:1)
    at Module._compile (module.js:570:32)
/opt/kae-1.0/src/cli/index.js:39
	.description('Welcome to NodeBB')
	 ^

TypeError: program.name(...).description is not a function
    at Object.<anonymous> (/opt/kae-1.0/src/cli/index.js:39:3)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/opt/kae-1.0/nodebb:5:1)
    at Module._compile (module.js:570:32)

[scottalanmiller]

So we aren't updating at the moment.

[scottalanmiller]

We have a fix...

rm -rf ./node_modules/eslint* ; npm i commander

[stacksofplates]

Single quotes don’t work. At least from FF on iOS.

[JaredBusch]

Regular single quote ? like ' this? '?'

[scottalanmiller]

Mobile interface is very different.

[NerdyDad]

Words are coming out differently in messages as well.

won:undefined:’:undefined:t instead of won't. Spacing is also an issue.

[JaredBusch]

There is one report of the Emoji plugin causing this.

https://github.com/NodeBB/nodebb-plugin-emoji/issues/4

I cannot replicate on my NodeBB community yet though.

[scottalanmiller]

@jaredbusch said in NodeBB 1.7.1 Update Issues:

There is one report of the Emoji plugin causing this.

https://github.com/NodeBB/nodebb-plugin-emoji/issues/4

I cannot replicate on my NodeBB community yet though.

Just removed it as it wasn't working anyway. Let's see if that changes anything.

[scottalanmiller]

Yup, quotes seem to work now.

[JaredBusch]

@jaredbusch said in NodeBB 1.7.1 Update Issues:

There is one report of the Emoji plugin causing this.

https://github.com/NodeBB/nodebb-plugin-emoji/issues/4

I cannot replicate on my NodeBB community yet though.

Ah, my forum was still on 1.6. Updating...

[Obsolesce]

I can't paste images from clipboard into here anymore.

[JaredBusch]

@tim_g said in NodeBB 1.7.1 Update Issues:

I can't paste images from clipboard into here anymore.

Works fine for me.

Also, @scottalanmiller emoji works on my 1.7.1 SO the problem is something you have done.

[JaredBusch]

@jaredbusch said in NodeBB 1.7.1 Update Issues:

Also, @scottalanmiller emoji works on my 1.7.1 SO the problem is something you have done.

That said, the button is not populating the pop up window, but they work.

[JaredBusch]

@scottalanmiller my plugin list.

jbusch@daermabb nodebb]$ sudo ./nodebb plugins
1/12 11:51:38 [1220] - info: Active plugins: 
	 - nodebb-plugin-composer-default
	 - nodebb-theme-persona
	 - nodebb-plugin-markdown
	 - nodebb-plugin-mentions
	 - nodebb-widget-essentials
	 - nodebb-rewards-essentials
	 - nodebb-plugin-soundpack-default
	 - nodebb-plugin-dbsearch
	 - nodebb-plugin-assign-newuser-to-group
	 - nodebb-plugin-emailer-smtp-complete
	 - nodebb-plugin-emoji-one
	 - nodebb-plugin-gravatar
	 - nodebb-plugin-imgbed
	 - nodebb-plugin-emoji
	 - nodebb-plugin-question-and-answer
	 - nodebb-plugin-shortcuts
	 - nodebb-plugin-imgur
	 - nodebb-plugin-youtube-embed
[jbusch@daermabb nodebb]$ 

[scottalanmiller]

I tried emoji + emoji-one and that didn't work. I tried them with and without emoji-extended.

All used to work. Stopped one day without any updates from our side.

[JaredBusch]

@scottalanmiller said in NodeBB 1.7.1 Update Issues:

I tried emoji + emoji-one and that didn't work. I tried them with and without emoji-extended.

All used to work. Stopped one day without any updates from our side.

These were all just updated to v2. That is the point.

nodebb-plugin-emoji-extended is dead as you know.
nodebb-plugin-emoji is the correct plugin.
nodebb-plugin-emoji-one is an emoji pack and requires nodebb-plugin-emoji

[scottalanmiller]

@jaredbusch said in NodeBB 1.7.1 Update Issues:

@scottalanmiller said in NodeBB 1.7.1 Update Issues:

I tried emoji + emoji-one and that didn't work. I tried them with and without emoji-extended.

All used to work. Stopped one day without any updates from our side.

These were all just updated to v2. That is the point.

nodebb-plugin-emoji-extended is dead as you know.
nodebb-plugin-emoji is the correct plugin.
nodebb-plugin-emoji-one is an emoji pack and requires nodebb-plugin-emoji

Right, and I tried them today. And it didn't work.

[JaredBusch]

@scottalanmiller said in NodeBB 1.7.1 Update Issues:

@jaredbusch said in NodeBB 1.7.1 Update Issues:

@scottalanmiller said in NodeBB 1.7.1 Update Issues:

I tried emoji + emoji-one and that didn't work. I tried them with and without emoji-extended.

All used to work. Stopped one day without any updates from our side.

These were all just updated to v2. That is the point.

nodebb-plugin-emoji-extended is dead as you know.
nodebb-plugin-emoji is the correct plugin.
nodebb-plugin-emoji-one is an emoji pack and requires nodebb-plugin-emoji

Right, and I tried them today. And it didn't work.

Right, but it works elsewhere he issue is your install.

[JaredBusch]

No issues on my forum with quotes either.

And the emoji show up on iOS. So not seeing them may just be a browser issue.