PowerShell - Create New AD User Using Prompts and Variables

wrx7m

I created the following PowerShell script that works to create a new AD user and respective attributes, as long as I update the script with the user's name every time I want to run it. Here is what I have:

Import-Module ActiveDirectory
New-ADUser -Name "John Doe" -GivenName "John" -Surname "Doe" -SamAccountName "John" -DisplayName "John Doe" -UserPrincipalName "John@upndomain.com" -Country "US" -EmailAddress John.Doe@email1.com -Path "OU=email1.com,OU=User Accounts,DC=ADDomain,DC=com" -AccountPassword(Read-Host -AsSecureString "Input Password") -Enabled $true
Set-ADUser -Identity John -Add @{Proxyaddresses="SMTP:John.Doe@email1.com", "smtp:John.Doe@email2.com", "smtp:John.Doe@email3.com", "smtp:John.Doe@email4.com", "smtp:John.Doe@email5.com", "smtp:John.Doe@email6.com"}
Add-ADGroupMember -Identity Office365Users -Members John

I would like to do something with prompts to set variables regarding the name. I have tried doing this, but can't get the combined variables with a period in between working properly for the email addresses, the space in between the first and the last name for name/display name and possibly adding them to the the various domains, both UPN and email. Here is what I have so far.

Import-Module ActiveDirectory
$GivenName = Read-Host -Prompt "Enter First Name"
$Surname = Read-Host -Prompt "Enter Last Name"
$SecurePW = Read-Host -Prompt "Enter a Password" -AsSecureString
New-Variable -Name $DisplayName = "${GivenName}${Surname}"
New-ADUser -Name "$DisplayName" `
           -AccountPassword $SecurePW  `
           -SamAccountName $GivenName `
           -DisplayName $DisplayName `
           -PasswordNeverExpires $True `
           -UserPrincipalName $GivenName + "@UPNDomain.com" `
           -Country US `
           -EmailAddress $GivenName + "." + $Surname + "@email1.com" `
           -Path "OU=email1.com,OU=User Accounts,DC=upn,DC=com" `
           -Enabled $True
Set-ADUser -Identity $GivenName -Add @{Proxyaddresses="SMTP:$GivenName.$Surname@email1.com", "smtp:$GivenName.$Surname@email2.com", "smtp:$GivenName.$Surname@email3.com", "smtp:$GivenName.$Surname@email4.com", "smtp:$GivenName.$Surname@email5.com", "smtp:$GivenName.$Surname@email6.com"}
Add-ADGroupMember -Identity Office365Users -Members $GivenName

I get an error starting at New-ADUser : A positional parameter cannot be found that accepts argument '+'. on line 6 char1. I have messed around with syntax several times, so it may or may not be "complete", but I do know that it is wrong LOL

JaredBusch

@wrx7m

-UserPrincipalName "$GivenName@UPNDomain.com" `
-EmailAddress "$GivenName.$Surname@email1.com" `

dafyre

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

       -UserPrincipalName $GivenName + "@UPNDomain.com" `

Try changing your lines like that to like this...
-UserPrincipalName "$GivenName@UPNDomain.com"

You'll need to do this for anything that has a plus sign in it.

Edit: You'll need to fix the Email Address too.

NerdyDad

You're going to need to do some concentanation on your usernames in order to get the period included in the spot you want. Take a look at my script. There is a place where it is concentanated for the first name and last name for the email address and last name + first initial for usernames.

https://mangolassi.it/topic/13324/creating-new-user-without-o365-with-powershell

NerdyDad

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

-EmailAddress $GivenName + "." + $Surname + "@email1.com" `

Here, I think you're going to want to try something like:
-join ($GivenName,".",$SurName,"@email1.com")

wrx7m

What about creating a new variable by combining two existing variables? (For the display name)

JaredBusch

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

What about creating a new variable by combining two existing variables? (For the display name)

Of course you can. But why clutter up more variables?

wrx7m

@JaredBusch - Well, it didn't work when I used the first 2 together. At least, with the syntax I had. Also, it would be nice to know how to do it. But, I would settle for getting the display name Jon Doe with a space in it using the 2 existing variables.

dafyre

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

@JaredBusch - Well, it didn't work when I used the first 2 together. At least, with the syntax I had. Also, it would be nice to know how to do it. But, I would settle for getting the display name Jon Doe with a space in it using the 2 existing variables.

$DisplayName="$GivenName $SurName" ?

wrx7m

@dafyre I'll try that. I think I may have already tried it. I did all sorts of iterations.

wrx7m

Import-Module ActiveDirectory
$GivenName = Read-Host -Prompt "Enter First Name"
$Surname = Read-Host -Prompt "Enter Last Name"
$SecurePW = Read-Host -Prompt "Enter a Password" -AsSecureString
$DisplayName = "$GivenName $Surname"
New-ADUser -Name $DisplayName `

Results in this error

New-ADUser : A positional parameter cannot be found that accepts argument '+'.
At \\FP02\it\Scripts\AD\AD-InitialUserCreationVariables.ps1:6 char:1
+ New-ADUser -Name $DisplayName `
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [New-ADUser], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.ActiveDirectory.Management.Commands.NewADUser

wrx7m

If I get rid of the attempt to combine the 2 existing variables into a 3rd, I get this error.

New-ADUser : A positional parameter cannot be found that accepts argument '+'.
At \\FP02\it\Scripts\AD\AD-InitialUserCreationVariables.ps1:5 char:1
+ New-ADUser -Name "$GivenName $Surname" `
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [New-ADUser], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.ActiveDirectory.Management.Commands.NewADUser

dafyre

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

If I get rid of the attempt to combine the 2 existing variables into a 3rd, I get this error.

New-ADUser : A positional parameter cannot be found that accepts argument '+'.
At \\FP02\it\Scripts\AD\AD-InitialUserCreationVariables.ps1:5 char:1
+ New-ADUser -Name "$GivenName $Surname" `
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [New-ADUser], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,Microsoft.ActiveDirectory.Management.Commands.NewADUser

If you did not fix UserPrincipalName and EmailAddress as well, it will still error.

JaredBusch

This is why you run things manually and not in scripts until you know WTF you are doing.

Use the PowerShell ISE, that is what it is for.

You also do not have the Country in quotes. It is a string value.

NerdyDad

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

What about creating a new variable by combining two existing variables? (For the display name)

$displayName = join ($GivenName," ",$SurName)

NerdyDad

@dafyre said in PowerShell - Create New AD User Using Prompts and Variables:

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

@JaredBusch - Well, it didn't work when I used the first 2 together. At least, with the syntax I had. Also, it would be nice to know how to do it. But, I would settle for getting the display name Jon Doe with a space in it using the 2 existing variables.

$DisplayName="$GivenName $SurName" ?

This would result in literally being given $GivenName $SurName whenever you ask for $DisplayName.

dafyre

@NerdyDad said in PowerShell - Create New AD User Using Prompts and Variables:

@dafyre said in PowerShell - Create New AD User Using Prompts and Variables:

@wrx7m said in PowerShell - Create New AD User Using Prompts and Variables:

@JaredBusch - Well, it didn't work when I used the first 2 together. At least, with the syntax I had. Also, it would be nice to know how to do it. But, I would settle for getting the display name Jon Doe with a space in it using the 2 existing variables.

$DisplayName="$GivenName $SurName" ?

This would result in literally being given $GivenName $SurName whenever you ask for $DisplayName.

That's what he wants as I see his code above.

JaredBusch

NerdyDad

@JaredBusch said in PowerShell - Create New AD User Using Prompts and Variables:

Corrected. Thank you sir.

wrx7m

@JaredBusch said in PowerShell - Create New AD User Using Prompts and Variables:

This is why you run things manually and not in scripts until you know WTF you are doing.

Use the PowerShell ISE, that is what it is for.

You also do not have the Country in quotes. It is a string value.

I am running it manually and I am running it in ISE.